fix: supports empty message object #2369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/dynamic-messaging #2369 +/- ##
=============================================================
- Coverage 51.82% 51.75% -0.08%
=============================================================
Files 149 149
Lines 12322 12338 +16
Branches 700 703 +3
=============================================================
- Hits 6386 6385 -1
- Misses 5831 5848 +17
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Seavenly
approved these changes
Mar 29, 2024
|
@wsbrunson Please review at your convenience, thanks! |
wsbrunson
approved these changes
Apr 3, 2024
| showPoweredBy: boolean, | ||
| layout: string, | ||
| |}; | ||
| export function calculateShowPoweredBy( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that an empty message object input (e.g. message: {}) results in a message render by populating message props align, position, and color with computed default values.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!